Skip to content

Python debugger support for Python 3 (in addition to Python 2) #4678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Python debugger support for Python 3 (in addition to Python 2) #4678

wants to merge 1 commit into from

Conversation

zmedico
Copy link

@zmedico zmedico commented May 23, 2021 •
edited
Loading

  • Added safe_ord compatibility to pass through int arguments
  • Fixed JerryDebugger to decode bytes as utf8 strings when necessary
  • Fixed WebSocket send_message method to use packed_data[0:1] bytes slice

JerryScript-DCO-1.0-Signed-off-by: Zac Medico zmedico@gmail.com

@zmedico zmedico force-pushed the jerry-debugger-support-python3-in-addition-to-python2 branch 3 times, most recently from 41e59b1 to 484fbe9 Compare May 23, 2021 23:21
@ossy-szeged ossy-szeged requested a review from galpeter May 26, 2021 10:29
@zmedico zmedico force-pushed the jerry-debugger-support-python3-in-addition-to-python2 branch 2 times, most recently from 99bab4c to 5961da7 Compare June 12, 2021 17:54
galpeter
galpeter requested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried running the debugger tests? ./tools/run-tests.py --jerry-debugger for me this returned various errors which should be also fixed for Python 3.

(I've did a quick hackish changes to resolve some of them: https://gist.github.com/galpeter/a6ac851b6ab113aaad62d60001c5df23 )

@zmedico zmedico force-pushed the jerry-debugger-support-python3-in-addition-to-python2 branch from 5961da7 to 622ec35 Compare January 1, 2022 22:37
@zmedico
Copy link
Author

zmedico commented Jan 1, 2022

Have you tried running the debugger tests? ./tools/run-tests.py --jerry-debugger for me this returned various errors which should be also fixed for Python 3.

(I've did a quick hackish changes to resolve some of them: https://gist.github.com/galpeter/a6ac851b6ab113aaad62d60001c5df23 )

I've included your changes, and the debugger tests do pass with them. Thank you! I will look into making you suggested safe_ord change now.

@zmedico
Python debugger support for Python 3 (in addition to Python 2)
22d8b90 
- Added safe_ord compatibility to pass through int arguments
- Fixed JerryDebugger to decode bytes as utf8 strings when necessary
- Fixed WebSocket send_message method to use packed_data[0:1] bytes slice

JerryScript-DCO-1.0-Signed-off-by: Zac Medico <zmedico@gmail.com>
@zmedico zmedico force-pushed the jerry-debugger-support-python3-in-addition-to-python2 branch from 622ec35 to 22d8b90 Compare January 1, 2022 23:17
@LaszloLango LaszloLango added this to the Release 3.0.0 milestone Nov 12, 2024
@lygstate
Copy link
Contributor

this can be closed, python3 is already supported?

@zmedico
Copy link
Author

zmedico commented Nov 14, 2024

this can be closed, python3 is already supported?

Thank you! Closing now.

@zmedico zmedico closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galpeter galpeter galpeter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zmedico @lygstate @galpeter @LaszloLango