Skip to content

Conversation

@stefanhaller
Copy link
Collaborator

This fixes a regression in 0.58.

Fixes #5181.

The previous code only worked by accident because KeyCtrlM and KeyEnter happened
to have the same value. Since the latest tcell update this is no longer true;
fix this by using the right constant that we should have used already before.
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 80dd6951
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (80dd695) Report Missing Report Missing Report Missing
Head commit (b486c79) 59415 51742 87.09%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#5186) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Line breaks are stripped when pasting multi-line text into Commit Summary

2 participants