-
Notifications
You must be signed in to change notification settings - Fork 73
Add type casting to CSV fields #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Libertie
wants to merge
12
commits into
jgile:master
Choose a base branch
from
Libertie:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f5220bb
Add type casting to CSV fields
Libertie 6125efa
Correct fields prop default
Libertie 524680c
Refactor to typeCast method + add error handling
Libertie 4bc1a68
Document new invalidFieldType text
Libertie ba37f17
Additional error handling for typeCast method
Libertie 7cf7ae2
Expand documentation for type casting
Libertie d628eff
Reorganize to eliminate redundancy in typeCast
Libertie 2e728c8
Filter csv map to prevent typeCast errors
Libertie 0c21a32
Reduce nesting in buildMappedCsv()
Libertie dfbc006
Bump cli-plugin-unit-jest version
Libertie e045a72
Update for republish on npmjs.com
Libertie ceb547b
Merge remote-tracking branch 'upstream/master'
Libertie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fieldVal.toLowerCase().trim() === 'false' ? false : !!string
Could be an option too but I do like the idea of being able to pass these other values. "on/off" also comes to mind.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have time to push a documentation update tomorrow and I'll add on/off to the boolean switch statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, just pushed a few more commits to handle on/off booleans, improve error handling, and better document the new functionality. Wow. This really turned into a big thing. 😅