Some modernisation. #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpliant library, i.e. the addition of a `module-info.java`. This is supported by Java 9 and later, but to be able to make a jar compatible with earlier versions we need to use an MRJAR (multi-release). This is supported in Java 8 and onwards, so that must become the lowest common denominator. For this reason, I have made this a major version bump. The change also necessitated updating some Maven plugins and dependencies including JUnit. As a result of updating JUnit, many deprecations needed to be fixed. The source is now warning free (with the need for a few suppression annotations). To recap, * Minimum Java version increased to Java 8. * A Multi-release Jar is built with JPMS support. The module name is the same as the package, `com.github.jgonian.ipmath`. * Various Maven plugins updated. * Testing dependencies updated. * Resulting deprecations fixed.
|
Hi @brett-smith, many thanks for the pull-request. On a first pass it looks good. I'll try to find some time to wrap it up and cut the new release. It'd be nice if you could also add a note in the README about versioning and Java 8. |
|
Hi @jgonian, and thanks for the fast response. I'll get on to that now! On a side note, I should point out that there were no changes to |
brett-smith
added a commit
to Nodal-VPN/nodal-core
that referenced
this pull request
Mar 27, 2025
…s preventing a 100% clean publish, as the choice is either (our own) snapshot of commons-ip-math 2.0.0 that has JPMS, or the upstream one in central that doesn't. Both are really unacceptable for publishing nodal to a public repository. It doesn't look like my PR jgonian/commons-ip-math#27 is going to be merged any time soon, so this will suffice for now. Both libraries are MIT so there is no complication there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came about due to a need for a fully JPMS compliant library, i.e. the addition of a
module-info.java. This is supported by Java 9 and later, but to be able to make a jar compatible with earlier versions we need to use an MRJAR (multi-release). This is supported in Java 8 and onwards, so that must become the lowest common denominator.For this reason, I have made this a major version bump. The change also necessitated updating some Maven plugins and dependencies including JUnit. As a result of updating JUnit, many deprecations needed to be fixed. The source is now warning free (with the need for a few suppression annotations).
To recap,
com.github.jgonian.ipmath.