Add typing throughout code base #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy96
requested changes
Dec 2, 2023
cpuguy96
requested changes
Dec 2, 2023
| return note_data, valid | ||
|
|
||
| def parse_txt_input(txt_file: list[str]) -> defaultdict(list): | ||
| def parse_txt_input(txt_file: list[str]) -> dict[str, dict[str or list[str]] or float or int ]: |
There was a problem hiding this comment.
Typing uses the Union operator |
| return sub('4', '1', sub('[MKLF]', '0', line)) #replaces extra notes: M, K, L, F; replaces 4 note | ||
|
|
||
| def parse_sm_input(sm_file: list[str]) -> tuple[defaultdict(list), bool]: | ||
| def parse_sm_input(sm_file: list[str]) -> tuple[dict[str, dict[str or list[str]] or float or int ], bool]: |
There was a problem hiding this comment.
Check my commit message. For Python version <3.10, I have to use OR instead of a Union operator. If you can test it from your end with a Python version 3.10+ and it still works then there shouldn't be any problem.
There was a problem hiding this comment.
Then Union[x, y, z] from typing should be used instead. As is, I don't think this PR passes pytype checks.
IMO the code base can be upgraded to Python 3.10+. 3.10 has been out for 2 years and it's worth using more modern features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.