Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/prettier-plugin-java/src/printers/expressions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
each,
findBaseIndent,
flatMap,
hasLeadingComments,
indentInParentheses,
isBinaryExpression,
isNonTerminal,
Expand Down Expand Up @@ -276,8 +277,11 @@ export default {
},
"primarySuffix"
);
const hasSuffixComments = children.primarySuffix.some(suffix =>
hasLeadingComments(suffix)
);
return group(
canBreakForCallExpressions || willBreak(suffixes)
canBreakForCallExpressions || hasSuffixComments
? [prefix, indent(suffixes)]
: [prefix, ...suffixes]
);
Expand Down Expand Up @@ -766,7 +770,7 @@ function printTemplate<
const parts = [begin, ...mids, end].map(image =>
join(hardline, image.split(prefix))
);
return [
return indent([
parts[0],
...map(
path,
Expand All @@ -780,5 +784,5 @@ function printTemplate<
"embeddedExpression" as IterProperties<T["children"]>
),
parts.at(-1)!
];
]);
}
14 changes: 14 additions & 0 deletions packages/prettier-plugin-java/test/unit-test/lambda/_input.java
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,16 @@ void singleLambdaWithBlockLastArgumentAndLongArguments() {
return f;
}
);

this.a(
aaaaaaaaaaaaaaaaaaaaaaaaaa,
bbbbbbbbbbbbbbbbbbbbbbbbbb,
cccccccccccccccccccccccccc,
dddddddddddddddddddddddddd,
e -> {
return f;
}
);
}

void singleLambdaWithBlockLastArgumentAndLongLambdaArgument() {
Expand Down Expand Up @@ -212,6 +222,10 @@ void argumentAfterLambdaWithBlock() {
}

void huggableArguments() {
A.b().c(() -> {
return d;
});

aaaaaaaaaaaaaaaaaaaaaaaa((bbbbbbbbbbbbbbbbbbbbbbbb, cccccccccccccccccccccccc, dddddddddddddddddddddddd) -> eeeeeeeeeeeeeeeeeeeeeeee.ffffffffffffffffffffffff());

a.b(c -> d -> eeeeeeeeee.ffffffffff(gggggggggg, hhhhhhhhhh, iiiiiiiiii, jjjjjjjjjj, kkkkkkkkkk));
Expand Down
14 changes: 14 additions & 0 deletions packages/prettier-plugin-java/test/unit-test/lambda/_output.java
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,16 @@ void singleLambdaWithBlockLastArgumentAndLongArguments() {
return f;
}
);

this.a(
aaaaaaaaaaaaaaaaaaaaaaaaaa,
bbbbbbbbbbbbbbbbbbbbbbbbbb,
cccccccccccccccccccccccccc,
dddddddddddddddddddddddddd,
e -> {
return f;
}
);
}

void singleLambdaWithBlockLastArgumentAndLongLambdaArgument() {
Expand Down Expand Up @@ -228,6 +238,10 @@ void argumentAfterLambdaWithBlock() {
}

void huggableArguments() {
A.b().c(() -> {
return d;
});

aaaaaaaaaaaaaaaaaaaaaaaa(
(
bbbbbbbbbbbbbbbbbbbbbbbb,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ class TemplateExpression {
String s = STR."You have a \{getOfferType()} waiting for you!";

String msg = STR."The file \{filePath} \{
file.exists() ? "does" : "does not"
} exist";
file.exists() ? "does" : "does not"
} exist";

String time = STR."The time is \{
// The java.time.format package is very useful
Expand Down Expand Up @@ -55,6 +55,6 @@ class TemplateExpression {
""";

PreparedStatement ps = DB."SELECT * FROM Person p WHERE p.last_name = \{
name
}";
name
}";
}