Fix history navigation #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmbake
approved these changes
Dec 14, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes history navigation issues by implementing a temporary input value mechanism that preserves user input while navigating through command history. The solution introduces a tmpInputValue state variable that stores the current input when the user starts browsing history and restores it when returning to the input field.
Key Changes:
- Added
tmpInputValuestate to preserve user input during history navigation - Updated history navigation logic to save/restore temporary input when navigating with arrow keys
- Refactored Enter key handler to clear temporary state and extract empty input check into a guard clause
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/terminal.history.spec.tsx | Added two new test cases to verify input preservation during history navigation and behavior when returning from history without prior input |
| src/index.tsx | Implemented tmpInputValue state and updated history navigation logic to preserve and restore user input, plus refactored Enter key handling for clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at closing the issues described in #66 .
Two additional tests were also created in order to ensure proper behavior from the component.
The approach consists in using an additional state variable
tmpInputValuewhich temporary stores the user input whilehe navigates through the history.
Close #66 .