fix: always quote control chars #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceone
force-pushed
the
fix/quote-control-chars
branch
2 times, most recently
from
b99a925 to
21afb78
Compare
None of the invisible ASCII Control chars 0 - 32 were replaced. This PR replaces them with a unicode representation, the same as go-logfmt does it. e.g. `\x00` → `"\u0000"` This is security critical, as currently `\r` and other things would be part of the raw log. It would e.g. allow via ANSI escape sequences to set information in a linux terminal, like the window name/title.
spaceone
force-pushed
the
fix/quote-control-chars
branch
from
21afb78 to
cf5ed75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the invisible ASCII Control chars 0 - 32 were replaced.
This PR replaces them with a unicode representation, the same as go-logfmt does it.
e.g.
\x00→"\u0000".This is security critical, as currently
\rand other things would be part of the raw log.It would e.g. allow with ANSI escape sequences to set information in a linux terminal like the window name.