Skip to content

Conversation

@jayvdb
Copy link

@jayvdb jayvdb commented Oct 19, 2019

No description provided.

@jrabbit
Copy link
Owner

jrabbit commented Oct 22, 2019

the cert fixtures don't need to be distributed imo (they need to be regenerated actually) docs is fine I guess to distribute. the project will be moving to poetry when i have the brain cycles for it idk if that impacts your motivations for this pr?

@jayvdb
Copy link
Author

jayvdb commented Oct 22, 2019

IIRC, the cert fixtures are needed to run the tests.

I'm packaging it at https://build.opensuse.org/package/show/home:jayvdb:py-taskwarrior/python-taskc

No worries wrt poetry / it would require some changes to MANIFEST.in , whenever that happens.

@jrabbit
Copy link
Owner

jrabbit commented Oct 22, 2019

Ah yeah, you do need them for the tests. That makes sense then!

@jrabbit
Copy link
Owner

jrabbit commented Oct 22, 2019

I took a peek at your buildlogs there you'll want docker.py for the tests (unused in the library code)

@jayvdb
Copy link
Author

jayvdb commented Oct 22, 2019

I suspect something broke in recent docker

ImportError: cannot import name 'Client' from 'docker' (/usr/lib/python3.7/site-packages/docker/init.py)

@jrabbit
Copy link
Owner

jrabbit commented Oct 28, 2019

Can you check if this is still needed? (I'm not sure if poetry includes everything you'd need by default)
the tests should be fixed now :)

@jrabbit jrabbit mentioned this pull request May 7, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants