Skip to content

Fix for getattr error in the admin #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for getattr error in the admin #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions adminsortable2/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,10 +485,11 @@ def save_new(self, form, commit=True):
"""
obj = super().save_new(form, commit=False)

order_field_value = getattr(obj, self.default_order_field, None)
if order_field_value is None or order_field_value >= 0:
max_order = self.get_max_order()
setattr(obj, self.default_order_field, max_order + 1)
if self.default_order_field:
order_field_value = getattr(obj, self.default_order_field, None)
if order_field_value is None or order_field_value >= 0:
max_order = self.get_max_order()
setattr(obj, self.default_order_field, max_order + 1)
if commit:
obj.save()
# form.save_m2m() can be called via the formset later on
Expand Down