Skip to content

Conversation

NguyenASang
Copy link

@NguyenASang NguyenASang commented Aug 18, 2023

Fix lag when changing brightness and brightness changes after respring

First, I don't have any devices with iOS 13+, so I need someone to test it on other iOS.

Before (actually not as much as the video, just slightly):

IMG_8413.MP4

After:

IMG_8414.MP4

@NguyenASang NguyenASang marked this pull request as draft August 19, 2023 05:32
@NguyenASang
Copy link
Author

One problem I have is after respring, the glyph and value of slide aren't updated immediately. I don't know if the problem is my code or yours because I don't have any device to test.

@NguyenASang NguyenASang marked this pull request as ready for review August 19, 2023 06:26
@NguyenASang
Copy link
Author

NguyenASang commented Aug 19, 2023

It was my fault, fixed it. Still need someone to test it on newer iOS version before merging.

@NguyenASang NguyenASang changed the title iOS 12 support and fix lag when changing brightness (hopefully) iOS 12 support and fix bugs Aug 21, 2023
@jschiefner
Copy link
Owner

jschiefner commented Sep 26, 2023

Cheers @NguyenASang thats a great set of contributions! I'll test it out in the coming days on my iPad that is still jailbroken on iOS 14 and i have to find other testers for iOS 13, 15 & 16, as i can't risk breaking compatibility for these platforms.

In the meantime i would like to make a test build on Github Actions - is there any way you can request to let your forked code make a CI pipeline run? I can't find any information on how to request them, just how i can approve them (https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks).

@NguyenASang
Copy link
Author

NguyenASang commented Sep 27, 2023

I'm not really sure how to do that. However, I just noticed that I haven't enabled the workflow on my fork, maybe that's why you can't run it?

@jschiefner
Copy link
Owner

@NguyenASang Did you enable workflows in your fork? if not please do and let's see if i can then approve it somehow.

@jschiefner
Copy link
Owner

@NguyenASang i enabled workflow runs for Pull Requests, please merge the main branch into your feature branch and push, i hope this should trigger the workflow. Also enable workflows in your fork settings if you can first.

@NguyenASang
Copy link
Author

NguyenASang commented Sep 27, 2023

It worked! But failed, I will try to fix

@NguyenASang
Copy link
Author

@jschiefner Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants