-
Notifications
You must be signed in to change notification settings - Fork 6
iOS 12 support and fix bugs #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can't test on iOS 13 - 15
One problem I have is after respring, the glyph and value of slide aren't updated immediately. I don't know if the problem is my code or yours because I don't have any device to test. |
It was my fault, fixed it. Still need someone to test it on newer iOS version before merging. |
Cheers @NguyenASang thats a great set of contributions! I'll test it out in the coming days on my iPad that is still jailbroken on iOS 14 and i have to find other testers for iOS 13, 15 & 16, as i can't risk breaking compatibility for these platforms. In the meantime i would like to make a test build on Github Actions - is there any way you can request to let your forked code make a CI pipeline run? I can't find any information on how to request them, just how i can approve them (https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks). |
I'm not really sure how to do that. However, I just noticed that I haven't enabled the workflow on my fork, maybe that's why you can't run it? |
@NguyenASang Did you enable workflows in your fork? if not please do and let's see if i can then approve it somehow. |
@NguyenASang i enabled workflow runs for Pull Requests, please merge the |
It worked! But failed, I will try to fix |
@jschiefner Done. |
Fix lag when changing brightness and brightness changes after respring
First, I don't have any devices with iOS 13+, so I need someone to test it on other iOS.
Before (actually not as much as the video, just slightly):
IMG_8413.MP4
After:
IMG_8414.MP4