Skip to content

Dependency Updates #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dependency Updates #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63d3d82
Updated Xterm.js to 3.10.1 and added package lock.
jsmecham Jan 23, 2019
370318b
Updated Etch to 0.14.0.
jsmecham Jan 23, 2019
bb86910
Removed outdated note about requiring Atom 1.17 or later.
jsmecham Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## Unreleased

* Updated Etch to 0.14.0.
* Updated Xterm.js to 3.10.1.
* Added package-lock.json to the repository.
* Updated CircleCI configuration for CircleCI 2.0.

## 0.5.7
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Terminal for Atom

A simple terminal for Atom that is based on the excellent [Xterm.js](http://xtermjs.org) and [node-pty](https://github.com/Tyriar/node-pty) projects. Works best with Atom 1.17 and later with support for Docks.
A simple terminal for Atom that is based on the excellent [Xterm.js](http://xtermjs.org) and [node-pty](https://github.com/Tyriar/node-pty) projects.

## Demo

Expand Down
4 changes: 2 additions & 2 deletions lib/terminal-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ export default class TerminalSession {
// Kill the Pseudoterminal (pty) Process
if (this.pty) this.pty.kill();

// Destroy the Terminal Instance
if (this.xterm) this.xterm.destroy();
// Dispose of the Terminal Instance
if (this.xterm) this.xterm.dispose();

// Notify any observers that this session is being destroyed.
this.emitter.emit('did-destroy', this);
Expand Down
Loading