Skip to content

Allow underscore and tilde in URI hostnames as per RFC 3986 #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DannyvdSluijs merged 4 commits into from
Nov 28, 2025
Merged

Allow underscore and tilde in URI hostnames as per RFC 3986 #853

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
542dc57
Allow more characters in URIs.
longwave Nov 28, 2025
7024d29
Update tests/Tool/Validator/UriValidatorTest.php
longwave Nov 28, 2025
8ae9111
Update changelog.
longwave Nov 28, 2025
e9f35f0
Be more specific.
longwave Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/JsonSchema/Tool/Validator/UriValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public static function isValid(string $uri): bool
$hierarchicalPattern = '/^
([a-z][a-z0-9+\-.]*):\/\/ # Scheme (http, https, ftp, etc.)
(?:([^:@\/?#]+)(?::([^@\/?#]*))?@)? # Optional userinfo (user:pass@)
([a-z0-9.-]+|\[[a-f0-9:.]+\]) # Hostname or IPv6 in brackets
([a-z0-9._~-]+|\[[a-f0-9:.]+\]) # Hostname or IPv6 in brackets
(?::(\d{1,5}))? # Optional port
(\/[a-zA-Z0-9._~!$&\'()*+,;=:@\/%-]*)* # Path (valid characters only)
(\?([^#]*))? # Optional query
Expand Down
1 change: 1 addition & 0 deletions tests/Tool/Validator/UriValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public function validUriDataProvider(): \Generator
yield 'Data URI' => ['uri' => 'data:text/plain;charset=utf-8,Hello%20World!'];
yield 'ISBN URN URI' => ['uri' => 'urn:isbn:0451450523'];
yield 'OASIS URN URI' => ['uri' => 'urn:oasis:names:specification:docbook:dtd:xml:4.1.2'];
yield 'Custom URI' => ['uri' => 'custom://reg_name/path/file.json'];
}

public function invalidUriDataProvider(): \Generator
Expand Down
Loading