Add ability to straighten bezier curves #1056
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to be able to configure bezier curve connectors to make a straight line when the difference between the two anchors is negligible.
In this PR I've "hijacked" the
marginparam as an easy way to add this functionality, where if the difference between anchors is less than the margin, theminorAnchoroffset is not added.Please let me know your thoughts on this.
It might be worthwhile exposing the
minorAnchorproperty through the params as well.I realize setting
minorAnchorto0would also cause the bezier to be straight, but we would like to keep that offset when they are different.One thought I had based on this PR is to scale the
minorAnchorbased on the difference between anchor points. So that if they are close together,minorAnchorgoes to 0, giving straight lines.