Add support for libassuan file sockets (WinGnuPG support) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golint was complaining about these existing, and we already use windows.ERROR_BROKEN_PIPE so it made sense to pull the others in too.
- Move os.NewSyscallError - Remove unused variable - Refactor code into dialAssuan and revert changes to dialPipe
- Have a constant for the polling timeout - Use more standard error handling - Don't open the pipe over and over if polling - Don't call strconv.Atoi if we know there's no valid text
|
When will we have a release with gpg support? Thanks! |
|
I too would like a new release now that wsl 2 is almost out. |
|
Add me to the list of waiting people |
|
Side note that my fork (wsl-relay) supports gpg and I've been using it with an edited version of Nimamoh's Script in WSL2 without problem |
ndimiduk
pushed a commit
to ndimiduk/npiperelay
that referenced
this pull request
Feb 27, 2024
This commit squishes the changeset presented on jstarks#6. That commit is then rebased onto albertony/npiperelay:fork
ndimiduk
pushed a commit
to ndimiduk/npiperelay
that referenced
this pull request
Feb 27, 2024
This commit squishes the changeset presented on jstarks#6. That commit is then rebased onto albertony/npiperelay:fork Co-authored-by: Lex Robinson <lex@lex.me.uk>
albertony
pushed a commit
to albertony/npiperelay
that referenced
this pull request
Feb 6, 2025
* Add support for libassuan file sockets (WinGnuPG support) (jstarks#6) This commit squishes the changeset presented on jstarks#6. That commit is then rebased onto albertony/npiperelay:fork Co-authored-by: Lex Robinson <lex@lex.me.uk> * address linter issues * Fix PR remarks --------- Co-authored-by: NZSmartie <nzsmartie@gmail.com> Co-authored-by: Lex Robinson <lex@lex.me.uk> Co-authored-by: Nick Dimiduk <ndimiduk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2 to resolve #1.
I left @NZSmartie's commits untouched, but I can rebase and squash if you like.