-
Notifications
You must be signed in to change notification settings - Fork 9
operator: update from operatorhub feedback #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,5 +4,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||||
| kind: Kustomization | ||||||
| images: | ||||||
| - name: controller | ||||||
| newName: quay.io/jumpstarter-dev/jumpstarter-operator | ||||||
| newName: quay.io/jumpstarte-dev/jumpstarter-operator | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Typo in image registry organization name. Line 7 contains a typo in the image repository path: Apply this fix: - newName: quay.io/jumpstarte-dev/jumpstarter-operator
+ newName: quay.io/jumpstarter-dev/jumpstarter-operator📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the typo in the image may be related to the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: Length of output: 802 🏁 Script executed: Length of output: 5109 @bkhizgiy You're absolutely correct! 🎯 The typo is indeed causing the
The fix is to revert the typo back to the correct image name as I suggested in my initial review comment. Once corrected, the check-bundle workflow will pass because there will be no diff between the committed file and the regenerated one. 🧠 Learnings used |
||||||
| newTag: latest | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| apiVersion: jumpstarter.dev/v1alpha1 | ||
| kind: Client | ||
| metadata: | ||
| name: client-sample | ||
| labels: | ||
| type: developer | ||
| spec: | ||
| username: "keycloak:user-name-in-keycloak" | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| apiVersion: jumpstarter.dev/v1alpha1 | ||
| kind: Exporter | ||
| metadata: | ||
| name: exporter-sample | ||
| labels: | ||
| type: nxp-imx8mm-evk | ||
| spec: {} | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| apiVersion: jumpstarter.dev/v1alpha1 | ||
| kind: ExporterAccessPolicy | ||
| metadata: | ||
| name: exporteraccesspolicy-sample | ||
| spec: | ||
| exporterSelector: | ||
| matchLabels: | ||
| lab: jumpstarter | ||
| policies: | ||
| - from: | ||
| - clientSelector: | ||
| matchLabels: | ||
| team: platform | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| apiVersion: jumpstarter.dev/v1alpha1 | ||
| kind: Lease | ||
| metadata: | ||
| name: lease-sample | ||
| spec: | ||
| clientRef: | ||
| name: client-sample | ||
| selector: | ||
| matchLabels: | ||
| board: rcar-s4 | ||
| duration: "1h" | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| ## Append samples of your project ## | ||
| resources: | ||
| - operator_v1alpha1_jumpstarter.yaml | ||
| - jumpstarter.dev_v1alpha1_client.yaml | ||
| - jumpstarter.dev_v1alpha1_exporter.yaml | ||
| - jumpstarter.dev_v1alpha1_exporteraccesspolicy.yaml | ||
| - jumpstarter.dev_v1alpha1_lease.yaml | ||
| # +kubebuilder:scaffold:manifestskustomizesamples |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| #!/bin/bash | ||
|
|
||
| # if directory community-operators does not exist, checkout from git@github.com:k8s-operatorhub/community-operators.git | ||
| if [ ! -d "community-operators" ]; then | ||
| git clone git@github.com:k8s-operatorhub/community-operators.git | ||
| fi | ||
|
|
||
| # ask if we want to start a new branch from main | ||
| read -p "Do you want to start a new branch from main? (y/n): " START_NEW_BRANCH | ||
| if [ "$START_NEW_BRANCH" == "y" ]; then | ||
| git fetch --all | ||
| read -p "Enter the name of the new branch: " NEW_BRANCH | ||
| git checkout remotes/origin/main -B $NEW_BRANCH | ||
| fi | ||
|
|
||
| cd community-operators | ||
|
|
||
| VERSION=$(grep "^ version:" ../../bundle/manifests/jumpstarter-operator.clusterserviceversion.yaml | awk '{print $2}') | ||
|
|
||
| echo "Updating community-operators to version ${VERSION}" | ||
|
|
||
| # make sure that the operators/jumpstarter-operator/${VERSION} directory exists | ||
| mkdir -p operators/jumpstarter-operator/${VERSION} | ||
|
|
||
| cp -v -r -f ../../bundle/* operators/jumpstarter-operator/${VERSION} | ||
|
|
||
| echo You can now review the changes and commit them. |
Uh oh!
There was an error while loading. Please reload this page.