-
Notifications
You must be signed in to change notification settings - Fork 4
Adding split-file diffs
#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey! @jtpio and @Zsailer I need more suggestions from you about working of panes and need of accept-reject buttons in split-file view. |
|
Screencast.From.2025-11-04.16-02-44.mp4 |
|
I have updated the PR description video. |
brichet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nakul-py for working on this, this is promising.
This is a very quick review, mostly about consistency, according to the screenshot below.
-
The filepath can be confusing
In this case, I provided a fake filepath, and the diff widget opened with the current editor filepath (which is wrong).
Applying the changes applies them to the current editor, in this casemarkdown.mdinstead ofanything.txt(as the command suggest).
We should probably throw an error if the file path is not correct.
I wonder if we should check that the file content is one of theoriginalSourceornewSourcefor consistency. -
Undo / Redo buttons
AFAIU we can currently only accept or reject all changes. If this is true, I don't think the Undo/Redo buttons are necessary because the widget close after the action.
I don't know how difficult it is, but it would be wonderful to be able to accept and reject each diff independently. Otherwise these buttons can probably be removed for now.
Just saw #37 that should fix it, thanks 🎉 |
Currently this case is also valid for |
This PR adds
split-fileview for diffs.Screencast.From.2025-11-04.21-06-17.mp4
CC @jtpio @Zsailer