Skip to content

Fix repo URL in package.json and some other CI checks #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 7, 2025
Merged

Fix repo URL in package.json and some other CI checks #2

merged 4 commits into from
Mar 7, 2025

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 6, 2025

This should help fix some parts of the failing check-release check on CI.

@jtpio jtpio added the maintenance Code repository maintenance label Mar 6, 2025
@jtpio jtpio changed the title Fix repo URL in package.json Fix repo URL in package.json and some other CI checks Mar 6, 2025
@jtpio jtpio mentioned this pull request Mar 6, 2025
Merged
@brichet
Copy link
Collaborator

brichet commented Mar 7, 2025 •
edited
Loading

Thanks @jtpio.

I guess the build test is expected to fail, because of the missing ISecretsConnector token ?

Parsed an error from text content: undefined Plugin 'jupyter-secrets-manager:plugin' failed to activate.

It should be fixed with #1

@jtpio
Copy link
Member Author

jtpio commented Mar 7, 2025

I guess the build test is expected to fail, because of the missing ISecretsConnector token ?

Yes I think this one is expected.

brichet
brichet reviewed Mar 7, 2025
View reviewed changes
@jtpio @brichet
Update package.json
a88f792 
Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>
brichet
brichet approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jtpio

@brichet brichet merged commit f909d00 into jupyterlab-contrib:main Mar 7, 2025
5 of 6 checks passed
@jtpio jtpio deleted the fix-repo-url branch March 7, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brichet brichet brichet approved these changes

Assignees

No one assigned

Labels

maintenance Code repository maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtpio @brichet