-
Notifications
You must be signed in to change notification settings - Fork 21
Add UI test for multiple python kernels in different environments #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
please update snapshots |
Thanks for doing this!! Looks like the bot is broken due to micromamba missing, we should make sure that micromamba 2.0.5 is installed. It's a requirement now for jupyterlite-xeus to work. |
please update snapshots |
😬 sorry I did not tell you, but since the action runs from main when you request it here, we need to patch it on the main branch before you can use it. Also we really need to use micromamba 2.0.5 since latest does not work well with jupyterlite-xeus for an obscure reason #199 |
OK, maybe it is worth a separate PR to update the CI workflow, then rebase this on top of that when it is merged. It can wait until next week anyway. |
0528231
to
4f7dee7
Compare
please update snapshots |
It seems the bot ran well and did not see new snapshots I've seen flaky ui-tests starting to happen in jupytercad this morning. Could a rerun make it work? |
One other possibility, is a mismatch between the JupyterLab version on the update-snapshots run and the one used by jupyterlite? |
I don't know. I gave up and manually pushed the changes images. |
await page.goto('lab/index.html'); | ||
|
||
const xpython = page | ||
.locator('[title="Python 3.13 (XPython) [env2]"]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.locator('[title="Python 3.13 (XPython) [env2]"]') | |
.locator('[title="Python 3.13 (XPython) [env1]"]') |
Since bqplot
is installed in env1
and that test imports bqplot, maybe that should be the one to start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous test uses env1
and confirms that bqplot
can be imported, so this is the same test but with env2
to confirm that it cannot be imported. I should probably add a note explaining this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah got it! Makes sense, thanks :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This PR adds a UI test for the functionality added in #225, the same kernel in multiple environments. The
ui-tests
framework now builds using two environments, the first is the same as before with multiple kernels, the second new one contains justxeus-python
and no extra python packages. There is already a test that the first python kernel importsbqplot
, the new test is that the second python kernel fails to importbqplot
as it is not installed.I have also updated the test channel to https://repo.prefix.dev/emscripten-forge-dev.