-
-
Notifications
You must be signed in to change notification settings - Fork 120
Feat(rnpsw): add example project #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat(rnpsw): add example project #222
Conversation
Jokotoye18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@just1and0 this PR adds the demo project as described. Please review when you get a chance 🙏
|
Thank a lot @Jokotoye18 for working on this PR! I see how helpful this will be for the community. I'll review and revert. |
just1and0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this update. I added some reviews.
| ## 🤝 Contributing | ||
|
|
||
| Feel free to contribute to improve the demo: | ||
|
|
||
| 1. Fork the repository | ||
| 2. Create a feature branch | ||
| 3. Make your changes | ||
| 4. Submit a pull request | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jokotoye18 we have a contribution guideline, you can reference that here rather that listing a new one.
See contribution.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't resolved yet
|
[nit] - @Jokotoye18 Could we rename the |
|
Asides the tiny recommended changes, PR LGTM ✅ Approving for now, trusting you'll make the necessary adjustments. |
|
I made the required changes @just1and0, please can you review again. |
This one is still waiting for approval @just1and0 |
|
@just1and0 I’m good with merging this as it just adds stuff to the |
just1and0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
just1and0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jokotoye18 please can you resolve the pending comments
| ## 🤝 Contributing | ||
|
|
||
| Feel free to contribute to improve the demo: | ||
|
|
||
| 1. Fork the repository | ||
| 2. Create a feature branch | ||
| 3. Make your changes | ||
| 4. Submit a pull request | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't resolved yet
Description
This pull request adds a demo project showcasing how to integrate and use the
react-native-paystack-webviewpackage.The demo provides a working example for developers to quickly understand how to implement the library in their React Native apps.
Key features:
Issue URL
N/A – This is a new feature contribution and not tied to any existing issue.
Before and After
react-native-paystack-webview. Includes basic payment flow and UI.🎥 Watch the demo video on Imgur