feat: add ability to customize access and refresh cookie keys/names #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users are now able to change the cookie names by setting env variables - defined JWT_ACCESS_COOKIE_NAME and JWT_REFRESH_COOKIE_NAME env variables - both are used to set the APICookieKey at class definition time - add samesite and httponly parameters to JwtAuthBase.set_access_cookie and JwtAuthBase.set_refresh_cookie methods - this allows for more customization of the cookie parameters that FastAPI sets on the response - every tests passes and other functionalities are as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
users are now able to change the cookie names by setting env variables
APICookieKeyname at class definition timesamesiteandhttponlyparameters to JwtAuthBase.set_access_cookie and JwtAuthBase.set_refresh_cookie methods