Skip to content

BE: Make it possible to hide exception stacktraces in web responses #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BE: Make it possible to hide exception stacktraces in web responses #1461

wants to merge 1 commit into from

Conversation

@Haarolean
Copy link
Member

@Haarolean Haarolean commented Oct 31, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #536

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added this to the 1.4 milestone Oct 31, 2025
@Haarolean Haarolean requested a review from a team as a code owner October 31, 2025 16:11
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes type/security Pull requests that address a security vulnerability labels Oct 31, 2025
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 31, 2025
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 31, 2025
Haarolean
Haarolean commented Oct 31, 2025
View reviewed changes
api/src/main/java/io/kafbat/ui/exception/GlobalErrorWebExceptionHandler.java
@Order(Ordered.HIGHEST_PRECEDENCE)
public class GlobalErrorWebExceptionHandler extends AbstractErrorWebExceptionHandler {

@Value("${misc.excludeStackTracesInWebResponses:false}")
Copy link
Member Author

@Haarolean Haarolean Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@germanosin not sure on the name, any better ideas?

Copy link
Member

@germanosin germanosin Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http.error.excludeStackTraces: true / false

@Haarolean Haarolean self-assigned this Oct 31, 2025
@Haarolean Haarolean moved this from Todo to In Review in Release 1.4 Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@germanosin germanosin germanosin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Haarolean Haarolean

Labels

hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature type/security Pull requests that address a security vulnerability

Projects

Release 1.4
Status: In Review

Milestone

1.4

Development

Successfully merging this pull request may close these issues.

BE: Make it possible to hide stacktraces in HTTP responses

3 participants

@Haarolean @germanosin