FEC-14416 check if portal element exists before querying it #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SivanA-Kaltura, can you please take a look? I'm unable to add reviewers because I only have read only access. |
MosheMaorKaltura
approved these changes
Mar 26, 2025
|
@MosheMaorKaltura, I don't have write permissions, so I can't merge, can you please do that? |
| @@ -85,7 +85,7 @@ class Overlay extends Component<OverlayProps, any> { | |||
| } else { | |||
| // Remove the overlay-active class only when overlay portal has a single child | |||
| const overlayPortalEl = getOverlayPortalElement(this.props.player); | |||
| if (overlayPortalEl!.childElementCount <= 1) { | |||
| if (overlayPortalEl && overlayPortalEl.childElementCount <= 1) { | |||
There was a problem hiding this comment.
with TS you can use ?
overlayPortalEl?.childElementCount <= 1
There was a problem hiding this comment.
No, because if either overlayPortalEl or childElementCount are undefined, then the expression will be resolved as undefined <= 1, which isn't allowed in TypeScript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
https://kaltura.atlassian.net/browse/FEC-14416
Fix:
Make sure that the portal element is not
nullorundefinedbefore accessing itschildElementCountproperty.Resolves FEC-14416