Skip to content

Conversation

clinton-encord
Copy link

When passing height='auto' to the WavesurferPlayer, it is not actually able to take automatically adjust height because the container defined in WavesurferPlayer doesn't have a height.

So realistically, someone who uses WavesurferPlayer would expect the player to take the height of its player container.

i.e.

<div style={{height: "500px"}}> //  I expect Wavesufer to take the height of this div
    <WavesurferPlayer height='auto'/>
</div>

@clinton-encord
Copy link
Author

Hi @katspaugh ! Could you run the workflows here?

@katspaugh
Copy link
Owner

@clinton-encord sorry for the late reply! I read the PR I'm not sure auto and 100% should be synonymous. According to MDN, auto means "The browser will calculate and select a height for the specified element."

I understand that the main issue that the outer container div that the React wrapper creates doesn't automatically inherit the height of its parent. So perhaps we should just always set its height to 100%?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants