Support multi files for linker #32
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd8a6ea375
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @elf_objs.first.without_section(".text").each do |section| | ||
| elf.sections << section |
There was a problem hiding this comment.
The new multi-object build only concatenates .text from every input, then copies all other sections (e.g., .data, .rodata, .bss, .symtab, relocation sections) from the first object only. This means any global data, constants, or relocations that live in later objects are silently dropped, so linking multiple inputs that define non-text symbols outside the first file will either produce missing data at runtime or fail to resolve relocations. To support multi-file linking, non-.text sections need to be merged (or at least appended) across all inputs, not just the first one.
Useful? React with 👍 / 👎.
No description provided.