Promote mounts to stable - part 1 #3380
Conversation
kcp-ci-bot
added
kind/feature
There was a problem hiding this comment.
Pull Request Overview
This PR promotes mounts to the stable API by introducing early returns and differentiating mounted workspaces from non‐mounted ones. Key changes include updating reconcile functions, indexers, and admission logic to use the new mount-based workspace specification and converting WorkspaceTypeReference fields from struct to pointer.
Reviewed Changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/reconciler/tenancy/workspace/workspace_reconcile_scheduling.go | Early exit added when a workspace is mounted. |
| pkg/reconciler/tenancy/workspace/workspace_reconcile_phase.go | Added mount check to skip phase reconciliation for mounted workspaces. |
| pkg/reconciler/tenancy/workspace/workspace_reconcile_metadata.go | Bypasses metadata reconciliation if workspace is mounted. |
| pkg/reconciler/tenancy/workspace/workspace_controller.go | Adjusted the InstallIndexers signature without altering functionality. |
| pkg/openapi/zz_generated.openapi.go | Updated schema definitions and descriptions to incorporate mount references. |
| pkg/indexers/workspace_test.go | Updated tests to reflect mount changes in workspace indexing. |
| pkg/indexers/workspace.go | Updated workspace indexing to use the new WorkspaceSpec.Mount field. |
| pkg/index/index_test.go | Modified test scenarios for mount handling and workspace lookups. |
| pkg/index/index.go | Updated state management and lookup logic to consider mounts instead of annotations. |
| pkg/admission/* | Updated admission validation logic and tests for pointer-based WorkspaceTypeReference and mounted workspaces. |
| config/* | Revised API resource schemas and export configurations to reflect mount spec changes. |
| cli/pkg/workspace/plugin/* | Updated CLI tests and logic to use pointer-based WorkspaceTypeReference. |
mjudeikis
force-pushed
the
mjudeikis/mounts.promote.part1
branch
2 times, most recently
from
74abaf7 to
81c7551
Compare
|
Sorry for being that guy but I don't think the release note is super helpful to users. Can we maybe rephrase it a bit, something like |
I always very grateful for "that guy" :D So keep doing it. Changed |
mjudeikis
force-pushed
the
mjudeikis/mounts.promote.part1
branch
3 times, most recently
from
25d9821 to
379dcad
Compare
On-behalf-of: @SAP mangirdas.judeikis@sap.com Signed-off-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT>
|
/retest |
1 similar comment
|
/retest |
|
@ntnn: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mjudeikis
force-pushed
the
mjudeikis/mounts.promote.part1
branch
from
379dcad to
ae3aa02
Compare
mjudeikis
force-pushed
the
mjudeikis/mounts.promote.part1
branch
from
ae3aa02 to
25c7f6b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: e264e2651d65cce1aed82bde0ba52b80108d4c1c
|
kcp-ci-bot
added
the
approved
Summary
This is half of the code from #3282 to promote mounts to spec.
This way we can get it out faster while we solve open questions how to "prefill data without compromising cardinality".
What Type of PR Is This?
/kind feature
/kind api-change
Related Issue(s)
Fixes #
Release Notes