Skip to content

Conversation

@kharshith-k
Copy link
Member

@kharshith-k kharshith-k commented Jun 26, 2025

Running tests on V6 TPU runner.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.48%. Comparing base (6d06085) to head (4b84da1).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21425      +/-   ##
==========================================
- Coverage   82.66%   82.48%   -0.19%     
==========================================
  Files         577      577              
  Lines       59419    59506      +87     
  Branches     9313     9330      +17     
==========================================
- Hits        49121    49084      -37     
- Misses       7898     8010     +112     
- Partials     2400     2412      +12     
Flag Coverage Δ
keras 82.30% <ø> (-0.19%) ⬇️
keras-jax 62.89% <ø> (-0.44%) ⬇️
keras-numpy 57.55% <ø> (-0.02%) ⬇️
keras-openvino 34.35% <ø> (+<0.01%) ⬆️
keras-tensorflow 64.12% <ø> (-0.01%) ⬇️
keras-torch 63.61% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kharshith-k and others added 10 commits June 30, 2025 08:34
Progress bar would always report the starting batch + 1 at the end of the batch. Now it takes into account `steps_per_execution` for the last batch reported.

Fixes keras-team#20861
Using `keras.ops.math.logsumexp` with an int for `axis` in a functional model would throw an error.
…eras-team#21429)

Arbitrary functions and classes are not allowed.

- Made `Operation` extend `KerasSaveable`, this required moving imports to avoid circular imports
- `Layer` no longer need to extend `KerasSaveable` directly
- Made feature space `Cross` and `Feature` extend `KerasSaveable`
- Also dissallow public function `enable_unsafe_deserialization`
…developed dtypes_new_test.py to use requires_tpu marker
@kharshith-k kharshith-k changed the title Running TPU tests on linux-x86-ct6e-44-1tpu Run tests on TPU Nov 5, 2025
Copy link
Collaborator

@hertschuh hertschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@kharshith-k
Copy link
Member Author

An observed was made that tests were silently falling back to CPU during execution even when TPU was available while running them on a TPU VM which lead to the suspicion that the same could be happening with current passing tests. its a good idea to log the device type on which tests are getting executed (cpu/cuda/tpu).

Copy link
Collaborator

@hertschuh hertschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, one last thing.

We want these tests to run only after the PR is approved, like the kokoro GPU tests. Do you know how to do that?

@kharshith-k
Copy link
Member Author

Hi @hertschuh, I'm not sure how to do that exactly, Should I add the TPU specific workflow in .kokoro/github/ubuntu/gpu/build.sh? Can you please share some resources regarding the same if you have any? In the mean time I'll do some reading from my end too!

@hertschuh
Copy link
Collaborator

Hi @hertschuh, I'm not sure how to do that exactly, Should I add the TPU specific workflow in .kokoro/github/ubuntu/gpu/build.sh? Can you please share some resources regarding the same if you have any? In the mean time I'll do some reading from my end too!

It looks like this would be a way to do it: https://github.com/orgs/community/discussions/25372#discussioncomment-3247688

But it means you need a separate yml file.

@kharshith-k
Copy link
Member Author

Hello @hertschuh , I've added the condition to check if the PR is reviewed and approved before running the TPU tests job. Can you please let me know if the change is valid?

Copy link
Collaborator

@hertschuh hertschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 11, 2025
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Nov 12, 2025
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 12, 2025
Copy link
Collaborator

@hertschuh hertschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last 2 nitpicks

@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Nov 13, 2025
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 13, 2025
@hertschuh hertschuh merged commit 2730d52 into keras-team:master Nov 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull Ready to be merged into the codebase size:M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants