Skip to content

Conversation

@jahorton
Copy link
Contributor

@jahorton jahorton commented Oct 3, 2025

WIth the changes in #14883, we are now safe to remove the fallback check that was the one place still utilizing ContextTracker.analyzeState. As a result... time for more dead code removal.

Build-bot: skip build:web
Test-bot: skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 3, 2025

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

@github-actions github-actions bot added the change Minor change in functionality, but not new label Oct 3, 2025
@keymanapp-test-bot keymanapp-test-bot bot changed the title change(web): remove ContextTracker.analyzeState change(web): remove ContextTracker.analyzeState 🚂 Oct 3, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S13 milestone Oct 3, 2025
@jahorton jahorton force-pushed the change/web/remove-old-alignment-and-transform-tokenization branch from 824de55 to a3f1a89 Compare October 7, 2025 17:01
WIth the changes in #14883, we are now safe to remove the fallback check that was the one place still utilizing ContextTracker.analyzeState.  As a result... time for more dead code removal.

Build-bot: skip build:web
Test-bot: skip
@jahorton jahorton force-pushed the change/web/remove-tracker-analyze-state branch from 58d2f7b to df7fec0 Compare October 7, 2025 20:21
@darcywong00 darcywong00 modified the milestones: A19S13, A19S14 Oct 11, 2025
…ion' into change/web/remove-tracker-analyze-state
@jahorton jahorton marked this pull request as ready for review October 16, 2025 16:20
Base automatically changed from change/web/remove-old-alignment-and-transform-tokenization to epic/autocorrect October 20, 2025 13:37
@jahorton jahorton merged commit 8c93941 into epic/autocorrect Oct 20, 2025
7 of 8 checks passed
@jahorton jahorton deleted the change/web/remove-tracker-analyze-state branch October 20, 2025 13:37
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change Minor change in functionality, but not new epic-autocorrect web/predictive-text/ web/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants