feat(web): implement search-path splitting for multi-tokenization conditions 🚂 #14970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
9068e40 to
b8457ec
Compare
jahorton
force-pushed
the
feat/web/multi-tokenization-splitting
branch
from
aa114a9 to
524ea1d
Compare
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
2 times, most recently
from
f3fc256 to
a6e14c5
Compare
jahorton
force-pushed
the
feat/web/multi-tokenization-splitting
branch
from
524ea1d to
4f2605a
Compare
When we start supporting more than one "space" for correction-searches, we may need to know which "space" (tokenization) a suggestion arose from. This way, we have a path forward for applying tokenization-dependent behaviors that may be required. Build-bot: skip build:web Test-bot: skip
…rvation transform
The new interface is being added as preparation for efficient multi-tokenization correction-search. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
a6e14c5 to
a03bc15
Compare
jahorton
force-pushed
the
feat/web/multi-tokenization-splitting
branch
from
4f2605a to
26d97fb
Compare
As an upcoming goal is to introduce a new SearchSpace type that will assist with context-caching across multiple tokenizaitons, it is wise to generalize SearchPath and functions utilizing it to accept any SearchSpace-implementing type as its parent. Build-bot: skip build:web Test-bot: skip
…le spaces Build-bot: skip build:web Test-bot: skip
This is to prepare for corrections from alternate tokenizations that could result from fat-fingering whitespace keys or similar effects. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
a03bc15 to
3f199ce
Compare
…ditions This is the most crucial aspect needed to properly model token-splitting once we start implementing whitespace fat-fingering. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
feat/web/multi-tokenization-splitting
branch
from
26d97fb to
a7f85da
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
2 times, most recently
from
0e70658 to
72798ba
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
72798ba to
e5083de
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 This is in the process of being significantly reworked and will eventually be discarded. It's currently being kept around in case previously-defined tests or approaches prove valuable for the rework; the "Files changed" tab can prove a very handy reference for that sort of thing at times. 🚧
Build-bot: skip build:web
Test-bot: skip