refactor(web): relocate definition of .sourceRangeKey to SearchPath, SearchSpace 🚂 #15103
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
…SearchSpace Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/relocate-source-range-key
branch
from
804e5d7 to
20c6f10
Compare
jahorton
changed the base branch from
refactor/web/complex-search-space-reuse
to
refactor/web/manage-true-inputs-on-path
…web/relocate-source-range-key
…web/relocate-source-range-key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.sourceRangeKeyproperty previously defined onContextTokenwill be very useful for validating certain conditions needed for the upcomingSearchClusterimplementation ofSearchSpace. AsContextTokenownsSearchSpaces, and not the other way around, establishing it as a member ofSearchSpaceprovides better, more direct access for the new upcoming use-case.Build-bot: skip build:web
Test-bot: skip