Skip to content

Fix: TypeError Implicit Conversion of HTTParty::Response into String #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikathea wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: TypeError Implicit Conversion of HTTParty::Response into String #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0098c34
fix for no implicit conversion of HTTParty::Response into String
erikathea Aug 13, 2014
2497f6f
use ruby > 1.8 to test in travis ci
erikathea Aug 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
language: ruby
rvm:
- 1.8.7
- 1.9.2
- 1.9.3
- 2.0.0-p247
1 change: 0 additions & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ PLATFORMS
DEPENDENCIES
fakeweb (~> 1.3.0)
geckoboard-push!
httparty (~> 0.8.1)
mocha (~> 0.10.0)
rake
rdoc
2 changes: 1 addition & 1 deletion lib/geckoboard/push.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def initialize(widget_key)
# Makes a call to Geckoboard to push data to the current widget
def push(data)
raise Geckoboard::Push::Error.new("Api key not configured.") if Geckoboard::Push.api_key.nil? || Geckoboard::Push.api_key.empty?
result = JSON.parse(self.class.post("/#{Geckoboard::Push.api_version || 'v1'}/send/#{@widget_key}", {:body => {:api_key => Geckoboard::Push.api_key, :data => data}.to_json}))
result = JSON.parse(self.class.post("/#{Geckoboard::Push.api_version || 'v1'}/send/#{@widget_key}", {:body => {:api_key => Geckoboard::Push.api_key, :data => data}.to_json}).body)
raise Geckoboard::Push::Error.new(result["error"]) unless result["success"]
result["success"]
end
Expand Down