feat: add paging #20
Open
feat: add paging #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces multi-page layout functionality to the kiosk application, allowing widgets to be organized across multiple pages with timed rotation capabilities. The changes maintain backward compatibility with single-page configurations while enabling more dynamic kiosk displays.
- Adds
Pagetype with configurable duration and widget arrays - Implements automatic page rotation with customizable timing
- Updates admin interface to support multi-page configuration and editing
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/client/src/utils/useWidgetConfig.ts | Updates widget config hook to use active widget context |
| packages/client/src/types/config.type.ts | Adds Page type and makes widgets optional for backward compatibility |
| packages/client/src/layout/WidgetDistributor.tsx | Wraps widget rendering with ActiveWidgetProvider |
| packages/client/src/layout/ConfigContext.tsx | Implements page rotation logic with timer management |
| packages/client/src/layout/ActiveWidgetConfigContext.tsx | New context for tracking active widget configuration |
| packages/client/src/App.tsx | Updates to use flattened widgets from context |
| packages/backend/src/types/kiosk.types.ts | Mirrors frontend type changes for Page structure |
| packages/backend/src/kiosk/kiosk.service.ts | Updates patch method to handle pages configuration |
| packages/admin/src/types/types.tsx | Adds pageDurationSec to MetaForm |
| packages/admin/src/types/kiosk.types.ts | Mirrors client-side type changes |
| packages/admin/src/pages/Widgets.page.tsx | Complete rewrite to support multi-page editing |
| packages/admin/src/pages/WidgetEditPage.tsx | Adds null check for optional widgets |
| packages/admin/src/pages/Meta.page.tsx | Adds page duration configuration field |
| packages/admin/src/pages/KioskDashboard.page.tsx | Updates to display page information |
| packages/admin/src/context/kiosk.context.tsx | Removes automatic navigation on kiosk update |
| packages/admin/src/components/KioskListItem.tsx | Adds explicit navigation to dashboard |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
berenteb
requested changes
Sep 14, 2025
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces multi-page layouts with timed rotation, per-page widget configs.