Skip to content

Support Chrome 111+ #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Chrome 111+ #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cdt-java-client/src/main/java/com/github/kklisura/cdt/services/impl/ChromeServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ private static <T> T request(Class<T> responseType, String path, Object... param
try {
URL uri = new URL(String.format(path, params));
connection = (HttpURLConnection) uri.openConnection();
connection.setRequestMethod("PUT");

int responseCode = connection.getResponseCode();
if (HttpURLConnection.HTTP_OK == responseCode) {
Expand Down
14 changes: 7 additions & 7 deletions ...ava-client/src/test/java/com/github/kklisura/cdt/services/impl/ChromeServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public void testGetTabs() throws IOException, ChromeServiceException, Interrupte

RecordedRequest request = server.takeRequest();
assertEquals(1, server.getRequestCount());
assertEquals("GET /json/list HTTP/1.1", request.getRequestLine());
assertEquals("PUT /json/list HTTP/1.1", request.getRequestLine());

assertFalse(tabs.isEmpty());
assertEquals(2, tabs.size());
Expand Down Expand Up @@ -138,7 +138,7 @@ public void testCreateTab() throws IOException, ChromeServiceException, Interrup

RecordedRequest request = server.takeRequest();
assertEquals(1, server.getRequestCount());
assertEquals("GET /json/new?some-tab-name HTTP/1.1", request.getRequestLine());
assertEquals("PUT /json/new?some-tab-name HTTP/1.1", request.getRequestLine());

assertEquals("", tab.getDescription());
assertEquals(
Expand Down Expand Up @@ -174,7 +174,7 @@ public void testCreateTabWithAboutBlankPage()

RecordedRequest request = server.takeRequest();
assertEquals(1, server.getRequestCount());
assertEquals("GET /json/new?about:blank HTTP/1.1", request.getRequestLine());
assertEquals("PUT /json/new?about:blank HTTP/1.1", request.getRequestLine());

assertEquals("", tab.getDescription());
assertEquals(
Expand Down Expand Up @@ -212,7 +212,7 @@ public void testActivateTab() throws IOException, ChromeServiceException, Interr
RecordedRequest request = server.takeRequest();
assertEquals(1, server.getRequestCount());
assertEquals(
"GET /json/activate/D4CEC22C995F1A9C8526737014CD436D HTTP/1.1", request.getRequestLine());
"PUT /json/activate/D4CEC22C995F1A9C8526737014CD436D HTTP/1.1", request.getRequestLine());

server.shutdown();
}
Expand Down Expand Up @@ -267,7 +267,7 @@ public void testCloseTabClearsDevTools()
RecordedRequest request = server.takeRequest();
assertEquals(1, server.getRequestCount());
assertEquals(
"GET /json/close/D4CEC22C995F1A9C8526737014CD436D HTTP/1.1", request.getRequestLine());
"PUT /json/close/D4CEC22C995F1A9C8526737014CD436D HTTP/1.1", request.getRequestLine());

server.shutdown();

Expand All @@ -292,7 +292,7 @@ public void testCloseTab() throws IOException, ChromeServiceException, Interrupt
RecordedRequest request = server.takeRequest();
assertEquals(1, server.getRequestCount());
assertEquals(
"GET /json/close/D4CEC22C995F1A9C8526737014CD436D HTTP/1.1", request.getRequestLine());
"PUT /json/close/D4CEC22C995F1A9C8526737014CD436D HTTP/1.1", request.getRequestLine());

server.shutdown();
}
Expand All @@ -312,7 +312,7 @@ public void testVersion() throws IOException, ChromeServiceException, Interrupte

RecordedRequest request = server.takeRequest();
assertEquals(1, server.getRequestCount());
assertEquals("GET /json/version HTTP/1.1", request.getRequestLine());
assertEquals("PUT /json/version HTTP/1.1", request.getRequestLine());

assertEquals("Chrome/63.0.3239.132", version.getBrowser());
assertEquals("1.2", version.getProtocolVersion());
Expand Down