Modernise #3
Open
Modernise #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Then the project doesn’t require the javax.annotation package and there’s no conflict with jakarta.annotation
I’m not sure whether this is necessary or what impact this has.
And rename the fromBundle method to just from
This helps when developing as you can see what the expected value is.
Instead show errors. I saw exceptions in the Java logs in VS Code and I frequently saw broken compiles where the Strings_ generated class wasn’t created. I’m hoping this improves that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for this code. I have modernised the dependencies and added the option to generate an
enum. Check it out... if you're still interested in this project, it would be neat to merge it and publish a new version, otherwise I'm happy to do a proper fork.Best regards!
Karl