Skip to content

Fix a logic error in deterministic PRNG with buffer overrun issue #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
concise wants to merge 1 commit into from
Closed

Fix a logic error in deterministic PRNG with buffer overrun issue #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions uECC.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2629,9 +2629,15 @@ int uECC_sign_deterministic(const uint8_t private_key[uECC_BYTES],
T_ptr[T_bytes] = V[i];
}
}
#if (uECC_CURVE == uECC_secp160r1)
T[uECC_WORDS] &= 0x01;
#if (uECC_CURVE == uECC_secp160r1)
#if (uECC_WORD_SIZE == 1)
T[uECC_N_WORDS - 1] &= 0x01;
#elif (uECC_WORD_SIZE == 4)
T[uECC_N_WORDS - 1] &= 0x00000001;
#elif (uECC_WORD_SIZE == 8)
T[uECC_N_WORDS - 1] &= 0x00000001ffffffff; // keep the lower 33 bits
#endif
#endif

if (uECC_sign_with_k(private_key, message_hash, T, signature)) {
return 1;
Expand Down