Skip to content

Conversation

youngbash88
Copy link

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #892

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: bashir <mohammadbashir266@gmail.com>
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign supercharge-xsy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot
Copy link
Collaborator

Welcome @youngbash88! It looks like this is your first PR to kmesh-net/kmesh 🎉

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @youngbash88, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've introduced a significant enhancement to our build system, enabling selective compilation of project binaries. Previously, running a build would compile all available applications. With this change, users can now specify which binaries they wish to build, offering improved flexibility and potentially reducing build times for specific development tasks. This is achieved through updates to the Makefile and associated build scripts to honor a new BINARIES environment variable.

Highlights

  • Selective Binary Compilation: Implemented a mechanism to allow users to specify which binaries to compile, rather than building all of them by default. This provides greater control over the build process.
  • Makefile Enhancements: Refactored the Makefile to introduce individual build targets for each binary and utilize a new BINARIES variable to control the compilation process. This modularizes the build system.
  • Build Process Integration: Updated the build.sh and hack/utils.sh scripts to propagate the BINARIES environment variable, ensuring the selective compilation feature is integrated into the overall build workflow, including containerized builds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Builds now can choose,Only what is needed made,Time saved, code compiles.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for selective binary compilation by allowing a BINARIES variable to be passed during the build process. The changes in the Makefile are well-structured, introducing individual build targets for each binary and a validation mechanism for the BINARIES variable. The BINARIES variable is correctly propagated through the build scripts into the Docker build environment. My main feedback is on a change in build.sh that could impact future maintainability by decoupling it from the main all target in the Makefile.

Comment on lines +47 to +49
make kmesh-bpf
make kmesh-ko
make all-binary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The all target in the Makefile is defined as all: kmesh-bpf kmesh-ko all-binary. Replacing make (which defaults to make all) with explicit calls for each prerequisite makes this script harder to maintain. If the Makefile's all target changes, this script would need a corresponding manual update to avoid incomplete builds.

It's better to rely on the Makefile to orchestrate the build by using a single make or make all command.

Suggested change
make kmesh-bpf
make kmesh-ko
make all-binary
make all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make build supports selectively compiling some of the binaries

2 participants