-
Couldn't load subscription status.
- Fork 18
Add license scan report and status #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed off by: fossabot <badges@fossa.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @fossabot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces FOSSA integration to the project, enabling automated license scanning. The primary impact is the addition of FOSSA status badges to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Welcome @fossabot! It looks like this is your first PR to kmesh-net/orion 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, which appears to be automated by FOSSA, adds a license scan status badge to your README.md. My review has identified a couple of minor issues with how the changes have been implemented. The new shield badge at the top of the file has been placed within an HTML comment, which will prevent it from being displayed. Additionally, the change removes the final newline character from the file, which is contrary to common best practices. I've provided specific comments and a suggestion to help resolve these issues.
|
|
||
| <!-- | ||
| [](/LICENSE) [](https://img.shields.io/github/license/kmesh-net/orion) | ||
| [](/LICENSE) [](https://img.shields.io/github/license/kmesh-net/orion) [](https://app.fossa.com/projects/git%2Bgithub.com%2Fkmesh-net%2Forion?ref=badge_shield) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status badges, including the newly added FOSSA badge, are located inside an HTML comment, which will prevent them from being rendered on the page. Given that the purpose of this pull request is to display a status badge, this is likely unintentional. To ensure the badges are visible, please move them outside of the <!-- ... --> comment block.
| [Apache License, Version 2.0](./LICENSE). | ||
|
|
||
|
|
||
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Fkmesh-net%2Forion?ref=badge_large) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change removes the trailing newline from the file. It is a widely-accepted best practice for text files to end with a newline character. Please add a newline at the end of the file.
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Fkmesh-net%2Forion?ref=badge_large) | |
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Fkmesh-net%2Forion?ref=badge_large) | |
Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.
Below are docs for integrating FOSSA license checks into your CI: