Skip to content

Conversation

@creydr
Copy link
Member

@creydr creydr commented Nov 25, 2025

Currently we don't run hack/update-codegen.sh on Dependabot PRs like #8801. This leads to failing "verify codegen" jobs.

This PR addresses it and runs hack/update-codegen.sh on dependabot PRs

@creydr creydr requested review from Cali0707 and twoGiants November 25, 2025 12:07
@knative-prow knative-prow bot requested review from aliok and pierDipi November 25, 2025 12:07
@knative-prow
Copy link

knative-prow bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.15%. Comparing base (6ae393a) to head (1f34bb9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8805   +/-   ##
=======================================
  Coverage   51.14%   51.15%           
=======================================
  Files         409      409           
  Lines       21360    21360           
=======================================
+ Hits        10924    10926    +2     
+ Misses       9584     9583    -1     
+ Partials      852      851    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@creydr
Copy link
Member Author

creydr commented Dec 3, 2025

/test reconciler-tests
/cc @Cali0707 @twoGiants @matzew

@knative-prow knative-prow bot requested a review from matzew December 3, 2025 08:28
@knative-prow
Copy link

knative-prow bot commented Dec 3, 2025

@creydr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_main 1f34bb9 link true /test reconciler-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant