-
Notifications
You must be signed in to change notification settings - Fork 169
Separate components auto update from auto-deps #3165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3165 +/- ##
==========================================
+ Coverage 59.39% 60.14% +0.75%
==========================================
Files 134 134
Lines 13500 13500
==========================================
+ Hits 8018 8120 +102
+ Misses 4539 4408 -131
- Partials 943 972 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/hold might have a better fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well in case you decide this is the better way:
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I have created a conditional execution of this script so it shouldnt interfere with general PRs. I will monitor in following days/weeks (when we get some deps updates) and see if this works as intended |
Seeing the annoyance of the verify check in PRs because of this merge of our custom components auto bump and the general knative-wide auto deps bump Im separating these (again).
We have to manually approve (and reopen to run tests) these PRs but it turn it doesn't block any "real PRs" that come in at unfortunate time when some components get bumped.