-
Notifications
You must be signed in to change notification settings - Fork 173
[release-1.20] Clean up auth for host builder #3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.20] Clean up auth for host builder #3300
Conversation
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.20 #3300 +/- ##
================================================
+ Coverage 52.79% 55.67% +2.87%
================================================
Files 134 134
Lines 13519 13516 -3
================================================
+ Hits 7138 7525 +387
+ Misses 5526 5061 -465
- Partials 855 930 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
twoGiants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, knative-prow-robot, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This might not work, there might be bug in springboot template. Seems we fixed it only after 1.20? |
|
Indeed: 1.20 release Nov 5; bug fix Nov 11 |
|
New backport PR #3301 |
This is an automated cherry-pick of #3298