Skip to content

Conversation

@knative-prow-robot
Copy link

This is an automated cherry-pick of #3298

fix: hidden flags username/password (and affiliated envvars) now work also for s2i and pack builder

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2025
@matejvasek matejvasek requested review from gauron99, lkingland and twoGiants and removed request for dsimansk and jrangelramos December 16, 2025 10:22
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.67%. Comparing base (c9d4c54) to head (a5c263b).

Files with missing lines Patch % Lines
cmd/client.go 8.33% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.20    #3300      +/-   ##
================================================
+ Coverage         52.79%   55.67%   +2.87%     
================================================
  Files               134      134              
  Lines             13519    13516       -3     
================================================
+ Hits               7138     7525     +387     
+ Misses             5526     5061     -465     
- Partials            855      930      +75     
Flag Coverage Δ
e2e-tests ?
integration-tests 54.67% <47.61%> (?)
unit-tests 46.74% <47.61%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@twoGiants twoGiants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2025
@gauron99
Copy link
Contributor

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, knative-prow-robot, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2025
@gauron99
Copy link
Contributor

This might not work, there might be bug in springboot template. Seems we fixed it only after 1.20?

@gauron99
Copy link
Contributor

Indeed: 1.20 release Nov 5; bug fix Nov 11
#3181

@gauron99
Copy link
Contributor

New backport PR #3301
Closing this one

@gauron99 gauron99 closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants