Skip to content

fix(func): reject invalid function names with consecutive hyphens (DNS-1035) #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
intojhanurag wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(func): reject invalid function names with consecutive hyphens (DNS-1035) #3313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d76471
validation added
intojhanurag Dec 20, 2025
d59b9b6
linting issue
intojhanurag Dec 20, 2025
dfca6c8
linting issue
intojhanurag Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/utils/names.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ type ErrInvalidNamespace error
// (e.g. 'my-name', or 'abc-1', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')
func ValidateFunctionName(name string) error {

if strings.Contains(name, "--") {
return ErrInvalidFunctionName(fmt.Errorf("function name '%v' cannot contain consecutive hyphens", name))
}

if errs := validation.IsDNS1035Label(name); len(errs) > 0 {
// In case of invalid name the error is this:
// "a DNS-1035 label must consist of lower case alphanumeric characters or '-',
Expand Down
1 change: 1 addition & 0 deletions pkg/utils/names_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func TestValidateFunctionName(t *testing.T) {
{"Example", false},
{"EXAMPLE", false},
{"42", false},
{"test--func", false},
}

for _, c := range cases {
Expand Down
Loading