Skip to content

Conversation

ryota-ka
Copy link

@ryota-ka ryota-ka commented Oct 3, 2020

This pull requests adds the support for Brotli, both of dynamic compression and precompiled .br files.
Brotli support is a missing piece that koa-static does have.

I've also updated supertest to the latest version as I needed .responseType('arraybuffer') in the test cases.

Closes #77

@ryota-ka
Copy link
Author

ryota-ka commented Oct 3, 2020

Hmm, the build for Node.js 8 is failing, but the version has reached its EoL.
Should we still support them?

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add "engines": ">= 10" inside the package.json file.

@ryota-ka
Copy link
Author

@dead-horse Ping for decision.
Is it possible to drop support for Node.js 8, as we live in 2020?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support for precompressed brotli

2 participants