Skip to content

Add validator support for pointer to struct #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add validator support for pointer to struct #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f02f8b3
Add validator support for pointer to struct. fix https://github.com/k…
May 21, 2018
8604e4b
Remove FlagLoader from DefaultLoader, because it's unusable, refer to…
Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions multiconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,11 @@ func NewWithPath(path string) *DefaultLoader {
}

e := &EnvironmentLoader{}
f := &FlagLoader{}
// FlagLoader is unusable right now, refer to: https://github.com/koding/multiconfig/issues/75
// f := &FlagLoader{}

loaders = append(loaders, e, f)
// loaders = append(loaders, e, f)
loaders = append(loaders, e)
loader := MultiLoader(loaders...)

d := &DefaultLoader{}
Expand Down
11 changes: 11 additions & 0 deletions validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,17 @@ func (e *RequiredValidator) processField(fieldName string, field *structs.Field)
return err
}
}
case reflect.Ptr:
if field.IsExported() && reflect.ValueOf(field.Value()).Elem().Kind() == reflect.Struct {
fieldName += "."
for _, f := range field.Fields() {
if err := e.processField(fieldName, f); err != nil {
return err
}
}
return nil
}
fallthrough
default:
val := field.Tag(e.TagName)
if val != e.TagValue {
Expand Down