Add support for 3d bounding box matching #585
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue(s)
Fixes KOL-5576
What change does this PR introduce and why?
Adds support for 3D annotations in
upload_object_detection_results.This PR leverages the same Pascal VOC logic used for 2D object detection and applies it to 3D object detection using an approximate IoU metric based on this implementation in Objectron.
Unlike the 2D case, where IoU has a straight-forward, closed-form solution, 3D IoU evaluation is often implemented in many different ways. For this reason, this PR also gives the user control the ability to use their own matching logic.
TODO:
Please check if the PR fulfills these requirements