Skip to content

Fix address deletion response #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kolenkoal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix address deletion response #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/addresses/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,7 @@ async def add_address(
name="Set an address to default.",
responses=UNAUTHORIZED_FORBIDDEN_ADDRESS_NOT_FOUND_RESPONSE,
)
async def set_address_to_default(
address_id: UUID, user: User = Depends(current_user)
):
async def set_address_to_default(address_id: UUID, user: User = Depends(current_user)):
address = await AddressDAO.set_to_default(address_id, user)

if not address:
Expand Down Expand Up @@ -88,9 +86,7 @@ async def get_user_addresses(user: User = Depends(current_user)):
name="Get certain address.",
responses=UNAUTHORIZED_FORBIDDEN_ADDRESS_NOT_FOUND_RESPONSE,
)
async def get_address_by_id(
address_id: UUID, user: User = Depends(current_user)
):
async def get_address_by_id(address_id: UUID, user: User = Depends(current_user)):
address = await AddressDAO.find_by_id(user, address_id)

if not address:
Expand Down Expand Up @@ -129,7 +125,5 @@ async def delete_user_address(
address_id: UUID,
user: User = Depends(current_user),
):
address = await AddressDAO.delete_address(user, address_id)

if not address:
return {"detail": "The address was deleted."}
await AddressDAO.delete_address(user, address_id)
return Response(status_code=status.HTTP_204_NO_CONTENT)