Skip to content

feat: support block volume mode #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

feat: support block volume mode #42

merged 1 commit into from
Oct 17, 2025

Conversation

MeinhardZhou
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

support block mode volume mount

Which issue(s) this PR fixes:

Fixes #35

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Support Block Mode Pv

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MeinhardZhou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2025
@MeinhardZhou
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 9, 2025
@MeinhardZhou MeinhardZhou self-assigned this Oct 9, 2025
@MeinhardZhou
feat: support block volume mode
4b7bb30 
Co-authored-by: Jiri 'Ghormoon' Novak <novak.jiri@poda.cz>
Co-authored-by: Meinhard Zhou <zhouenhua@bytedance.com>

Signed-off-by: Meinhard Zhou <zhouenhua@bytedance.com>
@MeinhardZhou MeinhardZhou force-pushed the feat/block_volumemode branch from 2e570f4 to 4b7bb30 Compare October 15, 2025 13:22
@ghormoon
Copy link
Contributor

I did some basic tests with purestorage in our environment and it seems to work. only what I've noticed (but i think this is also issue in the fs mode, so I suggest we track that as separate issue) is that there are being leftover devices not disconnected if there is misconfigured device id and it's not matched (and if not manually cleared up, a retry will fail, because it's already connected)

@MeinhardZhou
Copy link
Member Author

Since no one else has reviewed it for two weeks and the self-test passed. Proceed with the merge.

@MeinhardZhou MeinhardZhou merged commit 99b30cc into kubernetes-csi:master Oct 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@humblec humblec Awaiting requested review from humblec

Assignees

@MeinhardZhou MeinhardZhou

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to mount raw device？

3 participants

@MeinhardZhou @k8s-ci-robot @ghormoon