-
Notifications
You must be signed in to change notification settings - Fork 404
[v8.3.0] Create Helm Chart from Static Manifests #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
**What type of PR is this?** /kind feature **What this PR does / why we need it**: This PR convert our static deployment manifests from `deploy/kubernetes/*` into Helm Charts under `charts/*`, by running a convert script under `deploy/util/chart-releaser.sh`. Moreover, it handle the chart release with branch `gh-pages`, by integrate with https://github.com/helm/chart-releaser-action. The sample helm repo could find from https://alvistack.github.io/kubernetes-csi-external-snapshotter/index.yaml, by: helm repo add external-snapshotter https://alvistack.github.io/kubernetes-csi-external-snapshotter helm repo update helm search repo external-snapshotter Before each stable tag release, maintainers only required to: 1. Run the `./deploy/util/chart-releaser.sh` and update templates under `charts/*/templates/*` 2. Double confirm `charts/*/values.yml` with correct values, e.g. image tags 3. `git add --all --force charts/* && git commit` Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hswong3i The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @hswong3i. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Sorry @TerryHowe may we continuous the review for #1285 with this new PR? |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR convert our static deployment manifests from
deploy/kubernetes/*into Helm Charts undercharts/*, by running a convert script underdeploy/util/chart-releaser.sh.Moreover, it handle the chart release with branch
gh-pages, by integrate with https://github.com/helm/chart-releaser-action.The sample helm repo could find from https://alvistack.github.io/kubernetes-csi-external-snapshotter/index.yaml, by:
Before each stable tag release, maintainers only required to:
./deploy/util/chart-releaser.shand update templates undercharts/*/templates/*charts/*/values.ymlwith correct values, e.g. image tagsgit add --all --force charts/* && git commitWhich issue(s) this PR fixes:
Fixes #551
Fixes #622
Fixes #751