-
Notifications
You must be signed in to change notification settings - Fork 637
✨ Add node auto repair configuration for EKS managed node groups #5604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @afarbos. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c29aa17 to
308295b
Compare
|
@afarbos rebase is required for the PR |
308295b to
28ad4be
Compare
rebased |
28ad4be to
2e6af5e
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I also tried to add a e2e test here after I saw them. I am not sure how to run them here. |
|
/ok-to-test |
|
LGTM label has been added. Git tree hash: e9654264f42f3d4950b4533ce50f01074db3c139
|
2e6af5e to
e1c3fd9
Compare
|
/retest |
e1c3fd9 to
0d3c5de
Compare
|
/retest |
1 similar comment
|
/retest |
0d3c5de to
f2c01bf
Compare
|
/lgtm On to @kubernetes-sigs/cluster-api-provider-aws-maintainers for a second pair of eyes and approval |
|
LGTM label has been added. Git tree hash: e5dbb561cff2dffb3e1dafcb598d58a9fe81d02e
|
|
/assign @nrb @richardcase @dlipovetsky @Ankitasw |
|
/test pull-cluster-api-provider-aws-e2e-eks |
|
@afarbos: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for node auto repair configuration in EKS managed node groups. Node auto repair is a feature that allows EKS to automatically repair unhealthy nodes by replacing them, helping maintain cluster health and availability.
https://aws.amazon.com/about-aws/whats-new/2024/12/node-health-monitoring-auto-repair-amazon-eks/
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
NodeRepairConfigfield toAWSManagedMachinePoolSpecwith anenabledboolean fieldNodegroupRepairConfigToSDKandNodegroupRepairConfigFromSDKfunctionsChecklist:
Release note: