🌱 Bump CAPI to v1.11 and k8s to v1.33

[clebs]

What type of PR is this?
/kind support

What this PR does / why we need it:
This PR bumps CAPI to v1.11.0, and k8s to v1.33.3.

• Update all imports to v1beta2 types except for conditions staying in v1beta1.
• Adapt source code to work with v1beta2 and deprecated conditions.
• Manually update conversions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5593

Replaces #5624

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

Bump CAPI to v1.11 and k8s to v1.33

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ankitasw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @clebs!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @clebs. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[clebs]

@richardcase This PR here based on @bryan-cox's: #5720

Changes:

• Rebased the PR to main
• Fixed missing/wrong go modules
• Updated all imports to use the new v1beta2 API, except for conditions which stay on v1beta1
• Adapted all the code to properly use the new types
• Add adapters to use v1beta1.Conditions with v1beta1types
• Manually fix converters for FailureDomains

Current state:

• Code compiles
• Generation fails because of manual conversions required
• Working on linting issues

[chrischdi]

/ok-to-test

[raykrueger]

Should we be bumping KUBERNETES_VERSION_MANAGEMENT and KUBERNETES_VERSION_UPGRADE_FROM to target 1.33 in this file?

[cnmcavoy]

See my comment on the subnet filtering regression

[chrischdi]

We can ignore pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

It is permafailing also on periodics: https://storage.googleapis.com/k8s-triage/index.html?text=No%20Control%20Plane%20machines%20came%20into%20existence.%20&job=cluster-api-provider-aws-.*ci-artifacts&xjob=-release-

[chrischdi]

/test pull-cluster-api-provider-aws-e2e-clusterclass

[chrischdi]

I agree on the clusterctl one, this still fails already on the still running job: pull-cluster-api-provider-aws-e2e

[chrischdi]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-eks

[clebs]

/test pull-cluster-api-provider-aws-test

[chrischdi]

/lgtm

Let's see what the tests say.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 63ace2d4e0e410d0924b4df57a2df01d636dbcef

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[chrischdi]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-eks

[chrischdi]

/retest

[chrischdi]

/retest

[chrischdi]

/retest

[damdo]

@chrischdi we can wait after the janitor cleans things up, also maybe it helps to start them in small batches (e2e / e2e eks first, then the others)

[nrb]

/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

[chrischdi]

/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[chrischdi]

/test pull-cluster-api-provider-aws-e2e-clusterclass

[chrischdi]

/test pull-cluster-api-provider-aws-e2e-conformance

[chrischdi]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[chrischdi]

/retest

[chrischdi]

/test pull-cluster-api-provider-aws-e2e-clusterclass

Note:

We can ignore pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

It is permafailing also on periodics: storage.googleapis.com/k8s-triage/index.html?text=No%20Control%20Plane%20machines%20came%20into%20existence.%20&job=cluster-api-provider-aws-.*ci-artifacts&xjob=-release-

[chrischdi]

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

[k8s-ci-robot]

@clebs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-aws-e2e-eks-gc	8596a85	link	false	/test pull-cluster-api-provider-aws-e2e-eks-gc
pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts	852783a	link	false	/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
pull-cluster-api-provider-aws-e2e	fee302e	link	false	/test pull-cluster-api-provider-aws-e2e
pull-cluster-api-provider-aws-e2e-clusterclass	fee302e	link	false	/test pull-cluster-api-provider-aws-e2e-clusterclass
pull-cluster-api-provider-aws-e2e-eks	fee302e	link	false	/test pull-cluster-api-provider-aws-e2e-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.