Skip to content

Conversation

@AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Nov 23, 2025

What this PR does / why we need it:

As discussed in office hours, the machine pool area should have more contributors overall, and adding someone with a reviewer role could lead to improving this situation.

In my job, I regularly work on CAPA machine pool support, and therefore also worked on the generic parts in CAPI. Overall, there were probably more than contributed 10 PRs relating to that area. I've been a CAPA maintainer since 2024-07, reviewer since 2023-12. My work included major features such as AWSMachinePool machines support (CAPA) or MachineHealthCheck remediation support for machine pool machines (CAPI; pending review by the working group). I'm in office hours somewhat regularly and try to discuss important topics – until now particularly topics around machine pool API, contract and expected behavior (example from ~2023: how/whether to roll machine pool machines on KubeadmConfig changes). I've worked on, or looked into, the machine pool and machine controller codebase often enough to be pretty familiar.

My current goal as reviewer would be to help the working group stabilize and document the API and contract well, then later add or fix reasonable features.

@k8s-ci-robot
Copy link
Contributor

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Nov 23, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2025
@AndiDog AndiDog changed the title Add AndiDog as machine pool area reviewer 🌱 Add AndiDog as machine pool area reviewer Nov 23, 2025
@sbueringer sbueringer added the area/community-meeting Issues or PRs that should potentially be discussed in a Kubernetes community meeting. label Nov 24, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Nov 24, 2025
@sbueringer
Copy link
Member

sbueringer commented Nov 24, 2025

Thank you very much for stepping up!

I think technically the bar for reviewer is not met yet (https://github.com/kubernetes/community/blob/master/community-membership.md#reviewer), but +1 from my side.

I think given your engagement for MachinePools and your experience with MachinePools, it makes sense to give you the benefit of the doubt (I like the german word of "Vertrauensvorschuss" much more, but didn't find a good translation :)).

Anyway, thank you very much for your contributions and looking forward to more :).

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ae468c3773b1b36ad5e434f2fed305f2d7047d1

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you for stepping up @AndiDog! You've been extremely helpful with MachinePools (and elsewhere).

@richardcase
Copy link
Member

And from me this would be good

/lgtm

@chrischdi
Copy link
Member

/lgtm

Thanks @AndiDog for stepping up!

@sbueringer
Copy link
Member

I would recommend bringing it up during next office hours and then setting up a lazy consensus

@sivchari
Copy link
Member

/lgtm

Thanks @AndiDog for stepping up!

@fabriziopandini
Copy link
Member

Thank you very much for your contributions and looking forward to more!

I agree with @sbueringer, strengthening the reviewer team for MachinePool is important to bring this feature back on track as soon as possible.

/lgtm

Let's give a few more days for folks to chime in and celebrate because many folks are out for thanksgiving this week, otherwise I will merge before the next office hours.

As a side note, let me also remind to everyone interested in doing reviews that being on the reviewer list is not a pre-requisito to start performing reviews.

Then, if you are interested in doing reviews, just do it! Every opinion is more than welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/community-meeting Issues or PRs that should potentially be discussed in a Kubernetes community meeting. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants