-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Add AndiDog as machine pool area reviewer #13033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you very much for stepping up! I think technically the bar for reviewer is not met yet (https://github.com/kubernetes/community/blob/master/community-membership.md#reviewer), but +1 from my side. I think given your engagement for MachinePools and your experience with MachinePools, it makes sense to give you the benefit of the doubt (I like the german word of "Vertrauensvorschuss" much more, but didn't find a good translation :)). Anyway, thank you very much for your contributions and looking forward to more :). /lgtm |
|
LGTM label has been added. Git tree hash: 8ae468c3773b1b36ad5e434f2fed305f2d7047d1
|
mboersma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you for stepping up @AndiDog! You've been extremely helpful with MachinePools (and elsewhere).
|
And from me this would be good /lgtm |
|
/lgtm Thanks @AndiDog for stepping up! |
|
I would recommend bringing it up during next office hours and then setting up a lazy consensus |
|
/lgtm Thanks @AndiDog for stepping up! |
|
Thank you very much for your contributions and looking forward to more! I agree with @sbueringer, strengthening the reviewer team for MachinePool is important to bring this feature back on track as soon as possible. /lgtm Let's give a few more days for folks to chime in and celebrate because many folks are out for thanksgiving this week, otherwise I will merge before the next office hours. As a side note, let me also remind to everyone interested in doing reviews that being on the reviewer list is not a pre-requisito to start performing reviews. Then, if you are interested in doing reviews, just do it! Every opinion is more than welcome! |
What this PR does / why we need it:
As discussed in office hours, the machine pool area should have more contributors overall, and adding someone with a reviewer role could lead to improving this situation.
In my job, I regularly work on CAPA machine pool support, and therefore also worked on the generic parts in CAPI. Overall, there were probably more than contributed 10 PRs relating to that area. I've been a CAPA maintainer since 2024-07, reviewer since 2023-12. My work included major features such as AWSMachinePool machines support (CAPA) or MachineHealthCheck remediation support for machine pool machines (CAPI; pending review by the working group). I'm in office hours somewhat regularly and try to discuss important topics – until now particularly topics around machine pool API, contract and expected behavior (example from ~2023: how/whether to roll machine pool machines on
KubeadmConfigchanges). I've worked on, or looked into, the machine pool and machine controller codebase often enough to be pretty familiar.My current goal as reviewer would be to help the working group stabilize and document the API and contract well, then later add or fix reasonable features.